Fix routeros net put #595
Merged
Fix routeros net put #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
NilashishC
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #583 by searching for the sftp error message for non-existent files when interacting with RouterOS.
ISSUE TYPE
COMPONENT NAME
net_put.py
ADDITIONAL INFORMATION
The existing code searches for an error message, "No such file or directory". Using sftp with RouterOS instead results in "File doesn't exist".
Instead of searching the end of the string, be a bit more lenient on where the string is located when scanning. Since this code is only invoked on error, unless someone has a file with that string as part of a filename, we're not going to spuriously execute the
if-block on success. Even so, all we end up doing is removing a temporary file.There was no need to change
net_get.