[AnsibleArgSpecValidator] remove empty keys from task args before validation

[NilashishC]

SUMMARY

• When HAS_ANSIBLE_ARG_SPEC_VALIDATOR is False, we fallback to creating a MonkeyModule class and use that to leverage AnsibleModule class's argspec validation logic. However, the task args passed for validation do not have empty keys removed from them before this is done. This results in incorrect validation failures.

• remove_empties method is already defined in ansible.netcommon, but netcommon depends on utils and not vice-versa, we cannot import that method in here. So, the alternative was to copy it over for now.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

argspec_validate.py

[NilashishC]

Hmm, looks like this probably cannot be added here because of how some plugins (and their tests) are designed to work.

  TASK [utils_to_paths : Test filter and lookup plugin with empty list and mapping] ***
  task path: /home/runner/collections/ansible_collections/ansible/utils/tests/integration/targets/utils_to_paths/tasks/empty_members.yaml:14
  fatal: [localhost]: FAILED! => {
      "msg": "missing required arguments: var"
  }

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/c4db90ceefc849619191f310d79a3365

✔️ ansible-galaxy-importer SUCCESS in 5m 37s
✔️ build-ansible-collection SUCCESS in 8m 44s

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/696b6617d9204606b72848389775adb7

✔️ ansible-galaxy-importer SUCCESS in 10m 46s
✔️ build-ansible-collection SUCCESS in 8m 30s

[ashwini-mhatre]

@NilashishC Could you please add some tests if possible.otherwise LGTM

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/8b17714402d144f0b80ce243d0635fbc

✔️ ansible-galaxy-importer SUCCESS in 4m 22s
✔️ build-ansible-collection SUCCESS in 8m 55s