Fix deprecated options from MySQL 8.2 #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Installing the same version between the client and the server makes sense anyway. The incompatibility arise when you use mysqldump with --source-data. The the tool tries to perform a SHOW MASTER STATUS which is deprecated in MySQL 8.2+.
|
@dennisurtubia @betanummeric I realize now that I didn't consider #651 while working on this. I hope I didn't make things worst. In that case, I'm available to help fix things. This PR is now ready for review. |
Andersson007
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR:
mysql_db,mysql_info, andmysql_replicationmodules with MySQL versions 8.0.22, 8.0.23+, and 8.2+. Many terms have changed, such as MASTER -> REPLICATION SOURCE and MASTER_HOST -> SOURCE_HOST.mysqldump8.0 failed to dump MySQL 8.4 databases due to the change from MASTER to SOURCE.CommandResolverto simplify the code.For the command resolver, I chose the oldest query form as a key (
SHOW MASTER STATUS). I believe this is the best option since newer versions may differ between MariaDB and MySQL, ensuring that all keys remain homogeneous.ISSUE TYPE
COMPONENT NAME
module_utils/command_resolver(new)mysql_dbmysql_infomysql_replicationADDITIONAL INFORMATION
I inadvertently made a feature a duplicate (a second opinion would be appreciated) in the
mysql_replicationmodule. There were two options for the same functionality:changeprimary<- I have made this compatible with MySQL 8.0.23 as well.changereplication<- Should we consider deprecating this for simplicity?