Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ibm.storage_virtualize, which ibm.spectrum_virtualize was renamed to #307

Conversation

felixfontein
Copy link
Contributor

@felixfontein felixfontein commented Oct 30, 2023

Unfortunately step 4 from the checklist (#306) cannot be implemented since the original repository has been archived already.

Because of that I marked this PR as a draft, since the changelog entries now don't really make sense.

Closes #306.

Copy link
Contributor

@gotmax23 gotmax23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack. @Shilpi-J, can you take a look here to make sure this looks correct before we merge it?

8/changelog.yaml Outdated Show resolved Hide resolved
9/changelog.yaml Outdated Show resolved Hide resolved
Co-authored-by: Maxwell G <[email protected]>
Copy link

@sumitguptaibm sumitguptaibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change maintainer as provided in comments.

Copy link
Contributor

@Andersson007 Andersson007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there were no concerns raised by @sumitguptaibm except the maintainer name, we could merge the PR then. I pinged the original maintainer yesterday by email and she hasn't responded, so we can proceed.
UPDATE: Samit contacted me via email and Shilpi was in copy. Samit said everything looks great. So please folks proceed

@felixfontein felixfontein merged commit 0c8e761 into ansible-community:main Nov 3, 2023
2 checks passed
@felixfontein felixfontein deleted the rename-ibm.storage_virtualize branch November 3, 2023 11:42
@felixfontein
Copy link
Contributor Author

@Andersson007 @gotmax23 @sumitguptaibm @Shilpi-J thanks everyone!

@Andersson007
Copy link
Contributor

@felixfontein thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename included ibm.spectrum_virtualize to ibm.storage_virtualize
4 participants