Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ssl #18

Merged
merged 6 commits into from
Aug 27, 2024
Merged

feat: add ssl #18

merged 6 commits into from
Aug 27, 2024

Conversation

laurasgkadri98
Copy link
Contributor

@laurasgkadri98 laurasgkadri98 commented Aug 27, 2024 •
edited
Loading

  • Add secured https connection as an option.
  • Modify how service is started: give priority to cli and for empty values use config file. As last resort use default values.

RobPasMue
RobPasMue approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the required=False arg, this makes it clear that the args are optional. Apart from that all good =)

src/allie/flowkit/__main__.py Outdated Show resolved Hide resolved
src/allie/flowkit/config/_config.py Show resolved Hide resolved
@laurasgkadri98 laurasgkadri98 merged commit 30fb28e into main Aug 27, 2024
21 checks passed
@laurasgkadri98 laurasgkadri98 deleted the feat/add-ssl branch August 27, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laurasgkadri98 @RobPasMue