Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: uvicorn host #22

Merged
merged 1 commit into from
Sep 5, 2024
Merged

fix: uvicorn host #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/allie/flowkit/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,8 @@ def parse_cli_args():

def substitute_empty_values(args):
"""Substitute the empty values with configuration values."""
host = args.host or urlparse(CONFIG.flowkit_python_endpoint).hostname
port = args.port or urlparse(CONFIG.flowkit_python_endpoint).port
CONFIG.flowkit_python_endpoint = f"http://{host}:{port}"
CONFIG.flowkit_python_endpoint = f"http://0.0.0.0:{port}"
CONFIG.flowkit_python_workers = args.workers or CONFIG.flowkit_python_workers
CONFIG.use_ssl = (args.use_ssl.lower() == "true") if args.use_ssl is not None else CONFIG.use_ssl
CONFIG.ssl_cert_private_key_file = args.ssl_keyfile or CONFIG.ssl_cert_private_key_file
Expand All @@ -64,13 +63,12 @@ def main():
# Substitute the empty values with configuration values
substitute_empty_values(args)

host = urlparse(CONFIG.flowkit_python_endpoint).hostname
port = urlparse(CONFIG.flowkit_python_endpoint).port

# Run the service
uvicorn.run(
"allie.flowkit.flowkit_service:flowkit_service",
host=host,
host="0.0.0.0",
port=port,
workers=CONFIG.flowkit_python_workers,
ssl_keyfile=CONFIG.ssl_cert_private_key_file if CONFIG.use_ssl else None,
Expand Down