Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid gRPC FTS file modification #2736

Merged
merged 5 commits into from
Apr 24, 2024

Conversation

hpohekar
Copy link
Collaborator

@hpohekar hpohekar commented Apr 24, 2024

closes #2735

Do not upload file if it's already exists on remote.

@mkundu1
Copy link
Contributor

mkundu1 commented Apr 24, 2024

@hpohekar I think, in general, we still want to upload the file when it exists in the server as the client side file can be newer. A better check here may be not to upload the file if the local and remote absolute filepaths are identical (we additionally need to check if the local and remote hosts are same). Nevertheless, feel free to merge the current PR to fix the immediate issues in the regressions, we can consider this in a later PR. CC: @seanpearsonuk

@hpohekar
Copy link
Collaborator Author

hpohekar commented Apr 24, 2024

@hpohekar I think, in general, we still want to upload the file when it exists in the server as the client side file can be newer. A better check here may be not to upload the file if the local and remote absolute filepaths are identical. Nevertheless, feel free to merge the current PR to fix the immediate issues in the regressions, we can consider this in a later PR. CC: @seanpearsonuk

@mkundu1

Yes, 24R2 Nightly Dev Tests are passing now.

https://github.com/ansys/pyfluent/actions/runs/8814786215/job/24196569840

We will handle this in the other PR.

Thank you.

@hpohekar hpohekar merged commit 1ed6a81 into main Apr 24, 2024
26 of 27 checks passed
@hpohekar hpohekar deleted the fix/grpc_remote_file_modification_issue branch April 24, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid file modification in case of gRPC remote FTS
4 participants