-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: avoid gRPC FTS file modification #2736
Conversation
@hpohekar I think, in general, we still want to upload the file when it exists in the server as the client side file can be newer. A better check here may be not to upload the file if the local and remote absolute filepaths are identical (we additionally need to check if the local and remote hosts are same). Nevertheless, feel free to merge the current PR to fix the immediate issues in the regressions, we can consider this in a later PR. CC: @seanpearsonuk |
Yes, 24R2 Nightly Dev Tests are passing now. https://github.com/ansys/pyfluent/actions/runs/8814786215/job/24196569840 We will handle this in the other PR. Thank you. |
closes #2735
Do not upload file if it's already exists on remote.