Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: App utilities gRPC services #3552

Merged
merged 42 commits into from
Dec 19, 2024
Merged

feat: App utilities gRPC services #3552

merged 42 commits into from
Dec 19, 2024

Conversation

hpohekar
Copy link
Collaborator

@hpohekar hpohekar commented Dec 5, 2024

closes #3553

@hpohekar hpohekar changed the title feat: App utilities feat: App utilities gRPC services Dec 5, 2024
@hpohekar hpohekar marked this pull request as draft December 5, 2024 14:13
@hpohekar hpohekar marked this pull request as ready for review December 11, 2024 04:20
@hpohekar hpohekar marked this pull request as draft December 11, 2024 05:47
@hpohekar hpohekar marked this pull request as ready for review December 11, 2024 08:05
@seanpearsonuk
Copy link
Collaborator

Having difficulty finding GitHub comment after email notifications. In brief, I agree with this, thanks:
"
@seanpearsonuk @hpohekar FluentVersion doesn't support the patch version field. Also, FluentVersion is restricted to only few version numbers and won't work generally if this module is reused outside PyFluent.

I think it is better of simply return a tuple from this method.
"

@hpohekar
Copy link
Collaborator Author

Having difficulty finding GitHub comment after email notifications. In brief, I agree with this, thanks: " @seanpearsonuk @hpohekar FluentVersion doesn't support the patch version field. Also, FluentVersion is restricted to only few version numbers and won't work generally if this module is reused outside PyFluent.

I think it is better of simply return a tuple from this method. "

@seanpearsonuk We have reverted it to the original state. i.e. return f"{response.major}.{response.minor}.{response.patch}"

image

@hpohekar hpohekar enabled auto-merge (squash) December 19, 2024 10:04
@hpohekar hpohekar merged commit c192b84 into main Dec 19, 2024
29 checks passed
@hpohekar hpohekar deleted the feat/solver_utilities branch December 19, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement app utilities gRPC services
4 participants