Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses MarginalInstance and allows an incoming model #16

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jrising
Copy link

@jrising jrising commented May 14, 2023

This PR depends upon mimiframework/Mimi.jl#957, and consists of two main changes:

  1. Allowing an existing Model or MarginalModel to be passed into create_fair_monte_carlo. The idea is that a model that uses FAIR could have other components, so we don't want to create a new model from scratch when doing our Monte Carlo.
  2. We add other_mc_set(model, ii) and other_mc_get(model). The first of these is called each iteration to set any other parameters that need to be set as part of the MC. ii is the number of the iteration. The second is called after each iteration, to collect any other values of interest, which are added to an other key in the results dictionary.

Sorry that my editor removes spaces at the end of lines. Let me know if you want me to fix that.

@lrennels
Copy link
Collaborator

@jrising looks good to me! I will at some point add my Mimi-ified Monte Carlo functionality as well, since I have that written up for another paper in a private repo, but for now if this is working well for you I have no problem adding it in! I'll look at the Mimi PR as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants