Skip to content

Commit

Permalink
Wait 0.5 second for shell integration event, otherwise fall back to s…
Browse files Browse the repository at this point in the history
…endtext. (microsoft#24248)

For some reason, it seems like shell integration may take awhile to get
activated: microsoft#24239

Performance issue seemed to indicate exactly 3 second coming from the
https://github.com/microsoft/vscode-python/pull/24078/files#diff-5290f3097d5f92e3495c8abfbe095dff83c3f8de3dcac08ab2d0304f71bb412fR93,
so lets try reducing this to 0.5 second and let user fall back to
sendText. We may need further investigate why
onDidChangeTerminalShellIntegration may be taking awhile.
  • Loading branch information
anthonykim1 authored Oct 4, 2024
1 parent e5b47b9 commit 6bd34bf
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/client/common/terminal/service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ export class TerminalService implements ITerminalService, Disposable {
resolve(true);
},
);
const TIMEOUT_DURATION = 3000;
const TIMEOUT_DURATION = 500;
setTimeout(() => {
this.executeCommandListeners.add(shellIntegrationChangeEventListener);
resolve(true);
Expand Down

0 comments on commit 6bd34bf

Please sign in to comment.