-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #163 - tokens with backslashes #164
Conversation
…esponding literal part
Can you also add a regression test? I want to make sure that it not only parses, but is recognizing the correct sequence of input characters as a token. |
Sure. Could you please point out where I should add the test? I could not find (quickly) a test relating to .tokens file generation. |
Probably in TestJavaCodeGeneration.java. |
Thanks for the quick answer, I must have overlooked this file. I will create a test in the coming days. |
Found some time to write the tests. Please let me know if these regression tests should not be enough |
This is not a valid change. See #163 for details. |
You should at least merge the regression test
And you will see that the current implementation is wrong. I am happy if you fix it otherwise but it is still a bug IMO |
The error is a duplicate of #157 |
Fair enough, I figured that are two different things. Anyway, I am looking forward to the merge of your pull request #165 and will see if it works for me as well |
Fixes #163 - fixed token file generation for tokens with backslashes in their corresponding literal part