Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing Parser API in dts for javascript runtime #4402

Closed
wants to merge 1 commit into from
Closed

Add missing Parser API in dts for javascript runtime #4402

wants to merge 1 commit into from

Conversation

HerrCai0907
Copy link

No description provided.

@parrt parrt closed this Sep 4, 2023
@HerrCai0907 HerrCai0907 deleted the add-parser-dts branch September 5, 2023 01:03
@ericvergnaud
Copy link
Contributor

@HerrCai0907 can you reopen this ?

@parrt
Copy link
Member

parrt commented Sep 5, 2023 via email

@mike-lischke
Copy link
Member

@parrt yes, @ericvergnaud requested that already and I started to split the patch.

ericvergnaud
ericvergnaud reviewed Sep 7, 2023
View reviewed changes
runtime/JavaScript/src/antlr4/Parser.d.ts
@@ -41,5 +41,7 @@ export declare class Parser extends Recognizer<Token> {
setTokenStream(input: TokenStream): void;
notifyErrorListeners(msg: string, offendingToken: Token, err: RecognitionException | undefined): void;
getCurrentToken(): Token;

addParseListener(listener: any): void;
removeParseListener(listerner: any): void;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericvergnaud ericvergnaud ericvergnaud left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HerrCai0907 @ericvergnaud @parrt @mike-lischke