[Javascript] Fix broken package entrypoints #4411
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently as of 4.13.1 the entrypoint for
browser
is invalid, andmain
specifies theesm
build instead of thecommonjs
one.This results in commonjs based sources attempting to load esm syntax when addressing the sources using
main
.The error in
browser
causes this error when attempting to bundle the sources:Fixes
browser
field updated to fix the extension"dist/antlr4.web.js"
->"dist/antlr4.web.mjs"
main
field updated to point to the commonjs bundle->
"dist/antlr4.node.cjs"`Added
module
field to point to the esm bundle"module": "dist/antlr4.node.mjs"
More information on
main
vsmodule
can be found here: https://nodejs.org/api/packages.html#dual-commonjses-module-packages