fix: make package.json 'exports' work with typescript moduleResolution: 'bundler' #4503
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When importing antlr4 from a typescript project with
moduleResolution: "bundler"
, typescript will fail to resolve the .d.ts provided by antlr4. That's because typescript tries to resolve the exports with condition['types', 'import', 'default']
which does't match any of our declared exports.Change the
browser
condition todefault
solves the issue. It's also recommended in Node.js doc: