Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LexerNoViableAltException typescript class #4711

Merged

Conversation

happytomatoe
Copy link
Contributor

@happytomatoe happytomatoe commented Oct 3, 2024

Currently I am using latest antlr package from npm "antlr4": "^4.13.2" and I don't know how to check if an exception is the proposed class without importing js sources.

@ericvergnaud
Copy link
Contributor

Thanks for this. You also need to add it to error/index.d.ts !

@happytomatoe
Copy link
Contributor Author

Thanks for this. You also need to add it to error/index.d.ts !

Done

@ericvergnaud
Copy link
Contributor

You also need to sign the DCO. See https://github.com/antlr/antlr4/pull/4711/checks?check_run_id=31039893768 on how to do this.

@happytomatoe happytomatoe force-pushed the typescript-target/add-lexer-exception branch from 6a9d9b2 to 06ca635 Compare October 3, 2024 17:22
@happytomatoe happytomatoe force-pushed the typescript-target/add-lexer-exception branch from 06ca635 to 2a7904a Compare October 3, 2024 17:30
@happytomatoe happytomatoe reopened this Oct 3, 2024
@happytomatoe
Copy link
Contributor Author

You also need to sign the DCO. See https://github.com/antlr/antlr4/pull/4711/checks?check_run_id=31039893768 on how to do this.

Done

@jimidle
Copy link
Collaborator

jimidle commented Oct 5, 2024 via email

@ericvergnaud
Copy link
Contributor

@parrt blessed

@parrt parrt merged commit ce2557f into antlr:dev Oct 6, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants