Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Fix "mvn test" from root directory for java and kotlin. #4284

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

kaby76
Copy link
Contributor

@kaby76 kaby76 commented Oct 15, 2024

  • "mvn test" was not working in the root directory for java/ and kotlin/kotlin.
  • I don't know why, but running "mvn test" from the java/ directory worked fine. That is how I originally tested it when I made the change to add java20.
  • kotlin/kotlin actually has two scenarios in the pom.xml that were not programmed into desc.xml. This is now fixed. The problem was that kotlin/kotlin/examples/script/*.kt required a different entry point to the grammar. I'm not sure why I remastered the tests instead of just fixing the problem by adding the two test scenarios.
  • sql/clickhouse still fails but a fix is in the works. [build] Fix ClickHouse pom typo #4283
  • The output from mvn test > out.txt 2>&1 is here: out.txt

@kaby76 kaby76 marked this pull request as ready for review October 15, 2024 17:59
@teverett
Copy link
Member

@kaby76 thanks!

@teverett teverett merged commit ff0289a into antlr:master Oct 15, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants