[#65903] do not store components as state in YCommentsParent

antmicro · Oct 14, 2024 · fcc26fe · fcc26fe
1 parent 81001e1
commit fcc26fe
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/src/components/Comment.jsx b/src/components/Comment.jsx
@@ -245,11 +245,8 @@ const PopupButton = ({ icon, onClick, text, bgOnHover }) => {
 
 /** @param {{ ycomments: YComments }} */
 export const YCommentsParent = ({ ycomments, collaboration }) => {
-  let createWidget = ({ commentId }) => <YComment {...{ key: commentId, commentId, ycomments, collaboration }} />;
-  let createWidgets = () => ycomments.iterComments().map(createWidget);
-  let [widgets, setWidgets] = useState(createWidgets());
+  const [comments, setComments] = useState(ycomments.iterComments());
+  useEffect(() => ycomments.display().onUpdate(() => setComments(ycomments.iterComments())), [ycomments]);
 
-  ycomments.display().onUpdate(() => setWidgets(createWidgets()));
-
-  return <>{widgets}</>;
+  return comments.map(({ commentId }) => <YComment key={commentId} {...{ commentId, ycomments, collaboration }} />);
 };