Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autodetect endianness on export #16

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

albfan
Copy link
Contributor

@albfan albfan commented Nov 3, 2024

fixes #15

@glatosinski
Copy link
Member

Hello,

Thank you for your contribution. Ability to configure endianness during export is indeed a useful feature.

First things first, I'd fix the formatting of the code so that the CI will pass - there is one issue reported by yapf.

You can run code formatting with:

./.github/check_code_formatting.sh

@glatosinski glatosinski self-requested a review November 8, 2024 00:38
raviewer/__main__.py Show resolved Hide resolved
@albfan albfan force-pushed the export-detect-endianness branch from 743198e to 1e5b1ca Compare November 9, 2024 08:32
@albfan
Copy link
Contributor Author

albfan commented Nov 9, 2024

Reimplemented.

Test with:

pic803.zip

raviewer -f pic803.raw -e . --endianness little
raviewer -f pic803.raw -e . --endianness big
raviewer -f pic803.raw -e . --endianness auto

There's only a side effect for this. --endianness might be seen as a set for opening a file, but right now is only effective at --export

@antmicrobot antmicrobot merged commit 1e5b1ca into antmicro:main Nov 14, 2024
3 checks passed
@glatosinski
Copy link
Member

I introduced handling --endianness in GUI, thanks, merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

control reverse bytes on export
3 participants