Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose RDFLoader class to global context + Pass file format information from Loader to Parser + fix typo #108

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ashleysommer
Copy link

This is a rollup of three changes I have made to rdfstore-js sources while working on my current project.

I needed to override a prototype function on the RDFLoader Class from within another JS library, to add additional functionality. In order to do that I needed to expose RDFLoader to the global context. Several other classes such as RDFModel and QueryEngine are exposed globally so I think RDFLoader should also be accessible.

The second change is to pass a format parameter in the options struct from the RDFLoader to the selected parser via the tryToParse method. The N3 parser needs this option passed in to determine whether the file is Turtle or N3 in order to set some internal parsing options.

The final change is a small but nasty typo I found, which affects the use of the store.load helper.

@bensinober
Copy link

I backup @ashleysommer's PR, it is a necessary fix. Please merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants