-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix (stackY): Fix the point offset when set stackY. #6523
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@pearmini 对了,再麻烦老哥看看CI报错,我在本地跑和这里跑是一样的错误,不知道是不是某个依赖包更新导致的CI跑挂了 |
pearmini
approved these changes
Nov 19, 2024
Comment on lines
-102
to
+117
y0: inferredColumn(Y, fy), // Store original Y. | ||
y: column(V, fy), | ||
y1: column(V1, fy1), | ||
...newEncode, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里还有一个种写法,仅供参考:
encode: {
y0: inferredColumn(Y, fy), // Store original Y.
y: column(V, fy),
...mark.type === 'point' && { y1: column(V1, fy1) }
}
ci 统一修复~ |
hustcc
changed the title
transform(stackY): Fix the point offset when set stackY.
fix (stackY): Fix the point offset when set stackY.
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm test
passesDescription of change
fixed: #6506