Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set default offset of IndexBuffer #28

Merged
merged 5 commits into from
Sep 25, 2023
Merged

fix: set default offset of IndexBuffer #28

merged 5 commits into from
Sep 25, 2023

Conversation

xiaoiver
Copy link
Contributor

@xiaoiver xiaoiver commented Sep 25, 2023

🤔 This is a

  • New feature
  • Bug fix
  • Site / Document optimization
  • TypeScript definition update
  • Refactoring
  • Performance improvement
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

renderPass.setVertexInput(
  inputLayout,
  [
    {
      buffer: vertexBuffer,
    },
  ],
  {
    buffer: indexBuffer,
    offset: 0, // This should be omitted.
  },
);

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@xiaoiver xiaoiver merged commit 7c85d9e into release Sep 25, 2023
2 checks passed
@xiaoiver xiaoiver deleted the feat-model-api branch September 25, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant