Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release #9

Merged
merged 5 commits into from
Sep 18, 2023
Merged

Release #9

merged 5 commits into from
Sep 18, 2023

Conversation

xiaoiver
Copy link
Contributor

@xiaoiver xiaoiver commented Sep 18, 2023

🤔 This is a

  • New feature
  • Bug fix
  • Site / Document optimization
  • TypeScript definition update
  • Refactoring
  • Performance improvement
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@xiaoiver xiaoiver merged commit b6677c6 into master Sep 18, 2023
4 of 5 checks passed
@xiaoiver xiaoiver deleted the release branch September 18, 2023 05:34
frame();

return () => {
if (useRAF && id) {

Check warning

Code scanning / CodeQL

Useless conditional Warning test

This use of variable 'id' always evaluates to false.
const demo = demos[select.value];
node = demo();
document.body.append(node);
callback = await demo($container);

Check failure

Code scanning / CodeQL

Unvalidated dynamic method call High test

Invocation of method with
user-controlled
name may dispatch to unexpected target and cause an exception.
});

const cubeVertexSize = 4 * 10; // Byte size of one cube vertex.
const cubePositionOffset = 0;

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note test

Unused variable cubePositionOffset.

const cubeVertexSize = 4 * 10; // Byte size of one cube vertex.
const cubePositionOffset = 0;
const cubeColorOffset = 4 * 4; // Byte offset of cube vertex color attribute.

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note test

Unused variable cubeColorOffset.
const cubeVertexSize = 4 * 10; // Byte size of one cube vertex.
const cubePositionOffset = 0;
const cubeColorOffset = 4 * 4; // Byte offset of cube vertex color attribute.
const cubeUVOffset = 4 * 8;

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note test

Unused variable cubeUVOffset.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant