Skip DB migration on nodes where publish is disabled (stellar#4509)

anupsdf · Oct 21, 2024 · f9aa8e2 · f9aa8e2
2 parents 2493152 + 39ee2d9
commit f9aa8e2
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/history/HistoryManagerImpl.cpp b/src/history/HistoryManagerImpl.cpp
@@ -122,6 +122,12 @@ writeCheckpointFile(Application& app, HistoryArchiveState const& has,
 void
 HistoryManagerImpl::dropSQLBasedPublish()
 {
+    if (!mApp.getHistoryArchiveManager().publishEnabled())
+    {
+        // Publish is disabled, nothing to do
+        return;
+    }
+
     // soci::transaction is created externally during schema upgrade, so this
     // function is atomic
     releaseAssert(threadIsMain());
@@ -660,8 +666,6 @@ HistoryManagerImpl::appendLedgerHeader(LedgerHeader const& header)
     {
         mCheckpointBuilder.appendLedgerHeader(header);
 #ifdef BUILD_TESTS
-        CLOG_INFO(History, "Appending ledger header for ledger {} {}",
-                  header.ledgerSeq, mThrowOnAppend);
         if (header.ledgerSeq == mThrowOnAppend)
         {
             throw std::runtime_error("Throwing for testing");