Fix broadcast logging in rails 7.1+ #192
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Fixes issue with Rails 7.1. Previous fix sets
Anycable.logger
to an instance ofBroadcastLogger
with two loggers (console
and previous instance ofBroadcastLogger
). This nestedBroadcastLogger
breaks with following error:What changes did you make? (overview)
Use official
#broadcast_to
APIIs there anything you'd like reviewers to focus on?
Checklist