Decouple Redis from AnyCable #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palkan
force-pushed
the
feat/decouple-redis
branch
from
1d6aab9 to
b2d23f2
Compare
Envek
reviewed
Aug 13, 2024
palkan
commented
Aug 13, 2024
Co-authored-by: Andrey Novikov <[email protected]>
palkan
force-pushed
the
feat/decouple-redis
branch
from
5947128 to
835a31f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
AnyCable no longer depends on Redis in production, so shouldn't we.
Changes
AnyCable.broadcast_adapter(and removed all usages of the broadcast adapter)#with_redis { |conn| ... }instead of#redis). Although we do not use a connection pool by default, some users might want to go that way.