Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GO-4384 Add a non panicking method shouldcomponent #359

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

fat-fellow
Copy link
Collaborator


  • I understand that contributing to this repository will require me to agree with the CLA

Description

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 tech-docs
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

@fat-fellow fat-fellow requested review from mcrakhman, requilence and cheggaaa and removed request for mcrakhman December 11, 2024 11:21
Copy link

github-actions bot commented Dec 11, 2024

New Coverage 63.0% of statements
Patch Coverage 0.0% of changed statements (0/11)

Coverage provided by https://github.com/seriousben/go-patch-cover-action

@fat-fellow fat-fellow merged commit 1e0c2c7 into main Dec 11, 2024
4 checks passed
@fat-fellow fat-fellow deleted the go-4384-fix-membershipgettiers-panics branch December 11, 2024 13:15
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants