ignore flaky test: test_hard_fork_with_gap_in_roots #1130
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
PR #823 has caused the test:
test_hard_fork_with_gap_in_roots
to be flaky and the test:test_invalid_forks_persisted_on_restart
to fail consistently.Buildkite link: https://buildkite.com/organizations/anza/analytics/suites/agave/tests/018d9c52-ab10-74c0-b12d-9ebd22a1cb3a?branch=master#failed
However, @behzadnouri found that propagating
ContactInfo
more frequently resulted in these tests succeeding consistently. See: #823 (comment)We should not make these changes right now for 2 reasons:
ContactInfo
at the end of a Pull Request will make master incompatible with mainnet. So, we need to wait for the cluster to upgrade to v1.18Tracking issue here: #982
Summary of Changes
ignore the
test_invalid_forks_persisted_on_restart
test