Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore flaky test: test_hard_fork_with_gap_in_roots #1130

Merged

Conversation

gregcusack
Copy link

@gregcusack gregcusack commented Apr 30, 2024

Problem

PR #823 has caused the test: test_hard_fork_with_gap_in_roots to be flaky and the test: test_invalid_forks_persisted_on_restart to fail consistently.

Buildkite link: https://buildkite.com/organizations/anza/analytics/suites/agave/tests/018d9c52-ab10-74c0-b12d-9ebd22a1cb3a?branch=master#failed

However, @behzadnouri found that propagating ContactInfo more frequently resulted in these tests succeeding consistently. See: #823 (comment)

We should not make these changes right now for 2 reasons:

  1. Switching to use ContactInfo at the end of a Pull Request will make master incompatible with mainnet. So, we need to wait for the cluster to upgrade to v1.18
  2. These two tests failing as a result of slower contact info propagation is a general concern. These tests rely on contact-info propagation by a certain time which is not guaranteed. Furthermore, they're relying on propagation via the Pull path which is not ideal.

Tracking issue here: #982

Summary of Changes

ignore the test_invalid_forks_persisted_on_restart test

@gregcusack gregcusack requested a review from behzadnouri April 30, 2024 17:56
Copy link

@behzadnouri behzadnouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, Can you please also link to the tracking issue? thanks,

@gregcusack
Copy link
Author

lgtm, Can you please also link to the tracking issue? thanks,

oh shoot yes!

@gregcusack gregcusack added the automerge automerge Merge this Pull Request automatically once CI passes label Apr 30, 2024
@mergify mergify bot merged commit 5cee9dd into anza-xyz:master Apr 30, 2024
39 checks passed
@gregcusack gregcusack deleted the remove-test_hard_fork_with_gap_in_roots branch May 2, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants