v2.1: make new_from_bank to be only for tests (backport of #3455) #3484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* make new_from_bank to be only for tests * moved unnecessary use to cfg(test) * remove new line which breaks checks (cherry picked from commit 4e7f7f7)
|
These changes are back-ported because they are harmless and because they simplify development on the rpc/send-transaction-service which is needed to add choice of client version to those crates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is a comment that it is useful for tests, instead I added
#[cfg(test)].Summary of Changes
This is an automatic backport of pull request #3455 done by [Mergify](https://mergify.com).