Wen restart fix flaky test #3525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wen-coding
requested review from
KirillLykov,
brooksprumo,
carllin and
AshwinSekar
AshwinSekar
approved these changes
Nov 7, 2024
|
I'm not familiar with the code/test, and there's not enough context in the PR title/description/code for me to understand why the test is currently failing, and how this change fixes the issue. Luckily, there are other reviewers on this PR that I'm sure do have that context, so I'll defer to them! |
|
Thank you for fixing it, don't know the internal logic to understand how this fix works |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to check bank is frozen before getting its bankhash.