Ensures duplicates_lt_hash is Some if accounts lt hash is enabled #3534
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
At startup, if we're using accounts lt hash, then
generate_index()
is tasked with finding the duplicate accounts and tracking them. This value is used later when verifying accounts.However, if there are no duplicates, the value (since it is an Option), is returned as None. And then
verify_accounts
sees the None and concludes "since this value is None, I should not do lattice-based accounts verification, and instead use the original merkle-based accounts verification".This is wrong. Even if there are no duplicates,
generate_index()
must always returnSome
when accounts lt hash is enabled.Summary of Changes
Ensure duplicates is always Some when accounts lt hash is enabled.