Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update syscalls code in definitions #4196

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LucasSte
Copy link

Problem

SIMD-0178 introduces a new scheme for syscalls, whereby each syscall is assigned a defined integer according to a table.

Static syscalls, albeit added to the repository a while ago, don't yet follow the new code convention.

Summary of Changes

Created a file in define-syscalls to maintain all codes, updated the syscall declaration macros and the syscall registration in rBPF.

Ideally, we could create variables for the syscall names used in syscall registration on rBPF, but the concat_idents Rust macro isn't yet stabilized to allow a clean Rust code with a macro.

Copy link

mergify bot commented Dec 21, 2024

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant