Remove overly restrictive check_account_access for partitioned epoch rewards #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CriesofCarrots
force-pushed
the
simd-118-remove-writable-stake-restriction
branch
from
b4ea440 to
2cf1d93
Compare
Sidenote: my commit message just says |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #631 +/- ##
========================================
Coverage 81.9% 81.9%
========================================
Files 851 851
Lines 230475 230724 +249
========================================
+ Hits 188785 188995 +210
- Misses 41690 41729 +39 |
jstarry
previously approved these changes
Apr 7, 2024
joncinque
previously approved these changes
Apr 8, 2024
CriesofCarrots
force-pushed
the
simd-118-remove-writable-stake-restriction
branch
from
2cf1d93 to
1b404d5
Compare
|
Thanks! Force-pushed to get rid of the wip commit, so unfortunately need one of you to re- ✅ |
jstarry
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As per SIMD-0118, credits to stake accounts should be allowed during the rewards interval. The current implementation Errors all transactions that load a stake account as writable, overly restrictive.
Summary of Changes
Remove existing check_account_access() call in SVM
I did leave this method in the TransactionProcessingCallback trait, however. It's a generic-enough name that it could be used for something other than rewards-period restriction.
The test changes in this PR need rebasing on #617 to pick up the StakeError; I've included a temporary WIP commit to allow this to pass CI (and still demonstrate the change in logic here) in the meantime.DoneTowards #426