Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove multi slot test only StorableAccounts impl #972

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

jeffwashington
Copy link

Problem

stop mmapping storage files.
For shrink operations, we no longer hold a ref to account data. We have to lookup the account when we are creating new storages. In the naive implementation, we have to lookup the storage per slot once per account. We can do better by keeping a cache of the last storage lookup while writing. This is most easily done as part of StorableAccountsBySlot.

Summary of Changes

remove the test-only StorableAccounts impl that also tried to load accounts at store time. This will facilitate optimization of the validator use case.

Fixes #

@jeffwashington jeffwashington force-pushed the 4a122 branch 2 times, most recently from 01a468b to 5ae1e0c Compare April 22, 2024 18:54
@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.9%. Comparing base (b745dc9) to head (acfb70c).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master     #972     +/-   ##
=========================================
- Coverage    81.9%    81.9%   -0.1%     
=========================================
  Files         853      855      +2     
  Lines      231955   232097    +142     
=========================================
+ Hits       189984   190094    +110     
- Misses      41971    42003     +32     

@jeffwashington jeffwashington merged commit 57ab944 into anza-xyz:master Apr 23, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants