remove multi slot test only StorableAccounts impl #972
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
stop mmapping storage files.
For shrink operations, we no longer hold a ref to account data. We have to lookup the account when we are creating new storages. In the naive implementation, we have to lookup the storage per slot once per account. We can do better by keeping a cache of the last storage lookup while writing. This is most easily done as part of
StorableAccountsBySlot
.Summary of Changes
remove the test-only
StorableAccounts
impl that also tried to load accounts at store time. This will facilitate optimization of the validator use case.Fixes #