Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes AppendVec::file_name() #976

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

brooksprumo
Copy link

Problem

There's already a function for getting the file name for a storage: AccountStorageEntry::file_name(). And AccountStorageEntry is also what holds the slot and id. AppendVec doesn't know about this info, so use AccountsFile instead.

Summary of Changes

Replace calls to AppendVec::file_name() with AccountsFile::file_name().

@brooksprumo brooksprumo self-assigned this Apr 22, 2024
@brooksprumo brooksprumo marked this pull request as ready for review April 22, 2024 20:52
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.8%. Comparing base (14d6c79) to head (8c99a57).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master     #976     +/-   ##
=========================================
- Coverage    81.9%    81.8%   -0.1%     
=========================================
  Files         853      853             
  Lines      231797   231799      +2     
=========================================
- Hits       189845   189830     -15     
- Misses      41952    41969     +17     

@brooksprumo brooksprumo requested a review from HaoranYi April 24, 2024 13:33
Copy link

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brooksprumo brooksprumo merged commit d81ace8 into anza-xyz:master Apr 24, 2024
38 checks passed
@brooksprumo brooksprumo deleted the append-vec-file-name branch April 24, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants