Transaction Status: Add support for token-group and token-metadata interface instructions
#980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffalojoec
commented
Apr 22, 2024
buffalojoec
force-pushed
the
token-interface-rpc-parsing
branch
from
3696991 to
c842f7e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #980 +/- ##
========================================
Coverage 81.9% 81.9%
========================================
Files 853 855 +2
Lines 231955 232251 +296
========================================
+ Hits 189984 190384 +400
+ Misses 41971 41867 -104 |
joncinque
reviewed
Apr 23, 2024
buffalojoec
added
the
automerge
|
automerge label removed due to a CI failure |
mergify
bot
removed
the
automerge
buffalojoec
force-pushed
the
token-interface-rpc-parsing
branch
from
652a621 to
32d3e7a
Compare
buffalojoec
added
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
transaction-statuscrate, used by the RPC to parse instructions withjsonParsedencoding, supports most of the Token-2022 extensions. However, itdoesn't support the extensions that implement interfaces - such as
TokenMetadataandTokenGroup.Developers would benefit from being able to view parsed instructions - such as
initializeTokenMetadataandupdateGroupMaxSize- in RPCjsonParsedinstructions.
Summary of Changes
Add support for the Token Group and Token Metadata interface within
parse_tokento enable parsing of interface instructions.