Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Linux support #6

Merged
merged 7 commits into from
Sep 4, 2023
Merged

Conversation

assaron
Copy link
Contributor

@assaron assaron commented Sep 3, 2023

Addresses #5

  1. Limits number of created RtMidi objects.
  2. Adds a basic menu.

@aolsenjazz
Copy link
Owner

Thanks. Would you add linux to the .github/workflows/test.yml workflow matrix and check passing prior to merging? Prettier is also complaining - it's preconfigured so just need to run prettier in cli.

I remember running into some weirdness re. drivers when running tests in CI environment a while back on linux so may not be non-trivial.

I'll check what's required for linux publishing

@assaron
Copy link
Contributor Author

assaron commented Sep 4, 2023

OK, the tests are passing now.

@aolsenjazz aolsenjazz merged commit b30d3d5 into aolsenjazz:master Sep 4, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants