Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add otel_headers to OTel logic #44258

Closed
wants to merge 3 commits into from
Closed

Conversation

Kludex
Copy link
Contributor

@Kludex Kludex commented Nov 21, 2024

Does anyone know why just doing export OTEL_EXPORTER_OTLP_HEADERS='Authorization=your-write-token' on the terminal, before running airflow isn't enough? Airflow ignores environment variables?

Copy link

boring-cyborg bot commented Nov 21, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

airflow/config_templates/config.yml Outdated Show resolved Hide resolved
airflow/config_templates/config.yml Outdated Show resolved Hide resolved
@Kludex
Copy link
Contributor Author

Kludex commented Nov 22, 2024

I see an analogous PR that didn't have any tests: #42441

Can someone help me to move this forward? Also, the question no one is answering me: https://apache-airflow.slack.com/archives/C06K9Q5G2UA/p1732208803722989 😅

@Kludex
Copy link
Contributor Author

Kludex commented Nov 27, 2024

Since #44346 was merged, we don't need this.

@Kludex Kludex closed this Nov 27, 2024
@Kludex Kludex deleted the first-attempt-pr branch November 27, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants