dso: Check for NULL handle in apr_dso_sym #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The voidlinux package for apr on musl fails the
test_unload_library
test intestdso.c
without thisNULL
check. The test unloads the dso and then immediately tries to read a symbol from the unloaded dso, and assumes this fails. I found it was actually succeeding to read the symbol. Maybe musl'sdlsym()
function assumes you won't pass it aNULL
handle, and this test is invoking some UB.