Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For thread-debug builds, use error-checking mutexes #57

Closed
wants to merge 2 commits into from
Closed

For thread-debug builds, use error-checking mutexes #57

wants to merge 2 commits into from

Conversation

notroj
Copy link
Contributor

@notroj notroj commented Jun 11, 2024 

For thread-debug builds, use error-checking mutexes for proc_mutex_pthread:

* locks/unix/proc_mutex.c (proc_mutex_pthread_create):
  [APR_THREAD_PROC]: Set the mutex type to ERRORCHECK.

* test/testprocmutex.c (test_exclusive): Skip the trylock/timedlock tests for thread-debug builds since it triggers undefined behaviour with proc_pthread mutexes.

@notroj notroj force-pushed the proc_pthread-error-check branch from 38678e9 to f03c8b0 Compare June 11, 2024 15:50
notroj added 2 commits June 11, 2024 16:53
@notroj
For thread-debug builds, use error-checking mutexes for
0367793 
proc_mutex_pthread:

* locks/unix/proc_mutex.c (proc_mutex_pthread_create):
  [APR_THREAD_DEBUG]: Set the mutex type to ERRORCHECK.

* test/testprocmutex.c (test_exclusive): Skip the trylock/timedlock
  tests for thread-debug builds since it triggers undefined behaviour
  with proc_pthread mutexes.
@notroj
CI: Add a --enable-thread-debug job.
c182873
@notroj notroj force-pushed the proc_pthread-error-check branch from f03c8b0 to c182873 Compare June 11, 2024 15:54
@asfgit asfgit closed this in 8344a64 Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@notroj