[53.0.0_maintenance] perf: Use Cow in get_format_string in FFI_ArrowSchema (#6853) #6937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add cast_decimal bench * format * save * revert * criterion disable default features * address feedback
alamb
approved these changes
Jan 5, 2025
| @@ -685,66 +686,68 @@ impl TryFrom<&DataType> for FFI_ArrowSchema { | |||
| } | |||
| } | |||
|
|
|||
| fn get_format_string(dtype: &DataType) -> Result<String, ArrowError> { | |||
| fn get_format_string(dtype: &DataType) -> Result<Cow<'static, str>, ArrowError> { | |||
There was a problem hiding this comment.
I double checked that this is not a public API (and this is fine for a non breaking API release)
https://docs.rs/arrow-schema/latest/arrow_schema/?search=get_format_string
Looks good ✅
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?