CAMEL-20361: camel-jbang - Make jolokia pluggable for camel-platform-http-main #12985

kulagaIA · 2024-02-03T12:16:48Z

Description

camel-jolokia is now a context plugin with @DevConsole annotation.

I was not able to generate file core/camel-jolokia/src/generated/resources/META-INF/services/org/apache/camel/dev-console/jolokia with the camel-package-maven-plugin. This file was added by hands, and it is possible that something is wrong with camel-jolokia maven configuration, or something is wrong with the maven plugin (see https://camel.zulipchat.com/#narrow/stream/364655-camel-core-dev/topic/how.20to.20add.20context.20plugin/near/419592914 ).

Also added jolokia to example repo: apache/camel-examples#133

Tracking

https://issues.apache.org/jira/browse/CAMEL-20361

github-actions · 2024-02-03T12:17:02Z

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

First-time contributors require MANUAL approval for the GitHub Actions to run
You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.
You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.
Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.
⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

kulagaIA · 2024-02-03T12:17:58Z

/component-test camel-platform-http-main

Result ✅ The tests passed successfully

kulagaIA · 2024-02-03T12:18:15Z

/component-test camel-jolokia
EDIT: camel-jolokia is not a component thats why fail

Result ❌ The tests failed please check the logs

github-actions · 2024-02-03T12:18:25Z

🤖 The Apache Camel test robot will run the tests for you 👍

github-actions · 2024-02-03T12:18:41Z

🤖 The Apache Camel test robot will run the tests for you 👍

davsclaus · 2024-02-03T13:10:15Z

...kia/src/main/java/org/apache/camel/impl/jolokia/DefaultJolokiaHttpRequestHandlerFactory.java

+/**
+ * Default {@link org.apache.camel.console.DevConsoleRegistry}.
+ */
+@DevConsole("jolokia")


This is wrong. @devconsole is only for camel-console type of consoles.
You need to come up with another annotation such as JdkFactory.

core/pom.xml

kulagaIA · 2024-02-03T17:59:10Z

/component-test camel-jolokia

Result ✅ The tests passed successfully

github-actions · 2024-02-03T17:59:34Z

🤖 The Apache Camel test robot will run the tests for you 👍

davsclaus · 2024-02-04T08:38:10Z

core/camel-api/pom.xml

@@ -56,6 +56,13 @@
            <scope>compile</scope>
        </dependency>

+        <dependency>


camel-api should NOT have any other dependencies, this must be removed

davsclaus · 2024-02-04T08:39:23Z

core/camel-api/src/main/java/org/apache/camel/spi/JolokiaHttpRequestHandlerFactory.java

+/**
+ * Factory to abstract the creation of the Jolokia HttpRequestHandler.
+ */
+public interface JolokiaHttpRequestHandlerFactory extends StaticService {


We should make a generic factory that just returns Object or / Class T so we can use this for other stuff we can plugin into http-server in the future.

davsclaus · 2024-02-04T08:40:15Z

core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/AbstractCamelContext.java

@@ -370,6 +371,7 @@ protected void initPlugins() {
        camelContextExtension.lazyAddContextPlugin(AnnotationBasedProcessorFactory.class,
                this::createAnnotationBasedProcessorFactory);
        camelContextExtension.lazyAddContextPlugin(DumpRoutesStrategy.class, this::createDumpRoutesStrategy);
+        camelContextExtension.lazyAddContextPlugin(JolokiaHttpRequestHandlerFactory.class, this::createJolokiaHttpRequestHandlerFactory);


Jolokia should only be discovered if enabled, eg that jolokiaEnabled option in camel-main

davsclaus · 2024-02-04T08:42:17Z

jolokia should be option and not in core at all. Instead there should be a more generic factory for platform-http, that can load jolokia and whatelse we add in the future.

It should be platform-http that when it startup (doInit etc) will check if jolokia is configured to be enabled, and then use the factory to find the JAR (if present) and if present then create the factory and does what it need to do. If the JAR is not present then some exception is thrown. We do this elsewhere in Camel.

davsclaus · 2024-02-07T12:33:51Z

@kulagaIA I wonder if you will get more time for this before start of next week, as that is the deadline where we will cut the next 4.4 LTS release.

kulagaIA · 2024-02-07T12:38:03Z

@kulagaIA I wonder if you will get more time for this before start of next week, as that is the deadline where we will cut the next 4.4 LTS release.

Inteding to finish before 12.02.24, is it ok?

davsclaus · 2024-02-07T12:45:57Z

@kulagaIA I wonder if you will get more time for this before start of next week, as that is the deadline where we will cut the next 4.4 LTS release.
Inteding to finish before 12.07.24, is it ok?

Yes

kulagaIA · 2024-02-15T18:52:13Z

/component-test camel-platform-http-main camel-platform-http camel-platform-http-jolokia

Result ❌ The tests failed please check the logs

github-actions · 2024-02-15T18:52:41Z

🤖 The Apache Camel test robot will run the tests for you 👍

kulagaIA · 2024-02-15T19:02:58Z

/component-test camel-platform-http-main camel-platform-http camel-platform-http-jolokia

Result ✅ The tests passed successfully

github-actions · 2024-02-15T19:03:27Z

🤖 The Apache Camel test robot will run the tests for you 👍

kulagaIA · 2024-02-15T19:25:42Z

Made PlatformHttpPluginRegistry in camel-platform-http to be a generic factory for platform-http, that can load jolokia and whatelse we add in the future.
Also, apologies for messing up with the commit dates, wanted to finish before 4.4 LTS but got sick

davsclaus · 2024-02-16T05:59:50Z

...n/java/org/apache/camel/component/platform/http/plugin/DefaultJolokiaPlatformHttpPlugin.java

        var jolokiaContext = serviceManager.start();
        requestHandler = new HttpRequestHandler(jolokiaContext);
    }

    @Override
-    public void stop() {
+    public void doStop() {
        serviceManager.stop();


Add if (serviceManager != null)

components/camel-platform-http-jolokia/pom.xml

...rm-http-main/src/main/java/org/apache/camel/component/platform/http/main/MainHttpServer.java

davsclaus · 2024-02-17T19:08:18Z

Sorry we have now updated main to 4.5.0-SNAPSHOT so you may need to update this PR a little bit, thanks

…http-main PlatformHttpPluginRegistry was made to resolve plugins for camel-platform-http. Jolokia is now camel-platform-http plugin

…http-main (#12985)

…http-main (apache#12985) * CAMEL-20361: camel-jbang - Make jolokia pluggable for camel-platform-http-main PlatformHttpPluginRegistry was made to resolve plugins for camel-platform-http. Jolokia is now camel-platform-http plugin * fix version and null check * up version

…http-main (apache#12985)

…http-main (#12985)

…http-main (apache#12985) * CAMEL-20361: camel-jbang - Make jolokia pluggable for camel-platform-http-main PlatformHttpPluginRegistry was made to resolve plugins for camel-platform-http. Jolokia is now camel-platform-http plugin * fix version and null check * up version

…http-main (apache#12985)

github-actions bot added components core catalog camel-4 labels Feb 3, 2024

kulagaIA mentioned this pull request Feb 3, 2024

CAMEL-20253: camel-jbang - Add support for jolokia 2.x apache/camel-examples#133

Merged

davsclaus requested changes Feb 3, 2024

View reviewed changes

github-actions bot added the core-build-and-dependencies label Feb 3, 2024

kulagaIA requested a review from davsclaus February 3, 2024 18:02

davsclaus requested changes Feb 4, 2024

View reviewed changes

kulagaIA force-pushed the camel-jbang-make-jolokia-pluggable branch from ca3fea2 to 95323bb Compare February 15, 2024 18:51

github-actions bot removed the core label Feb 15, 2024

kulagaIA force-pushed the camel-jbang-make-jolokia-pluggable branch from 95323bb to 579fe34 Compare February 15, 2024 19:02

kulagaIA requested a review from davsclaus February 15, 2024 19:06

davsclaus reviewed Feb 16, 2024

View reviewed changes

kulagaIA requested a review from davsclaus February 17, 2024 10:48

davsclaus approved these changes Feb 17, 2024

View reviewed changes

kulagaIA force-pushed the camel-jbang-make-jolokia-pluggable branch from 9a248bb to 84b7820 Compare February 17, 2024 20:06

kulagaIA added 3 commits February 18, 2024 02:08

CAMEL-20361: camel-jbang - Make jolokia pluggable for camel-platform-…

5ce29b2

…http-main PlatformHttpPluginRegistry was made to resolve plugins for camel-platform-http. Jolokia is now camel-platform-http plugin

fix version and null check

84b7820

up version

35870dc

davsclaus merged commit d622cef into apache:main Feb 18, 2024
2 of 3 checks passed

davsclaus added a commit that referenced this pull request Feb 18, 2024

CAMEL-20361: camel-jbang - Make jolokia pluggable for camel-platform-…

889c886

…http-main (#12985)

vishal-bihani pushed a commit to vishal-bihani/camel that referenced this pull request Feb 18, 2024

CAMEL-20361: camel-jbang - Make jolokia pluggable for camel-platform-…

3ac09c7

…http-main (apache#12985)

davsclaus added a commit that referenced this pull request Feb 18, 2024

CAMEL-20361: camel-jbang - Make jolokia pluggable for camel-platform-…

1d9ea74

…http-main (#12985)

vishal-bihani pushed a commit to vishal-bihani/camel that referenced this pull request Feb 18, 2024

CAMEL-20361: camel-jbang - Make jolokia pluggable for camel-platform-…

f3081e5

…http-main (apache#12985)

kulagaIA deleted the camel-jbang-make-jolokia-pluggable branch February 21, 2024 17:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CAMEL-20361: camel-jbang - Make jolokia pluggable for camel-platform-http-main #12985

CAMEL-20361: camel-jbang - Make jolokia pluggable for camel-platform-http-main #12985

kulagaIA commented Feb 3, 2024 •

edited

Loading

github-actions bot commented Feb 3, 2024

kulagaIA commented Feb 3, 2024 •

edited by github-actions bot

Loading

kulagaIA commented Feb 3, 2024 •

edited

Loading

github-actions bot commented Feb 3, 2024

github-actions bot commented Feb 3, 2024

davsclaus Feb 3, 2024

kulagaIA commented Feb 3, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Feb 3, 2024

davsclaus Feb 4, 2024

davsclaus Feb 4, 2024

davsclaus Feb 4, 2024

davsclaus commented Feb 4, 2024

davsclaus commented Feb 7, 2024

kulagaIA commented Feb 7, 2024 •

edited

Loading

davsclaus commented Feb 7, 2024

kulagaIA commented Feb 15, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Feb 15, 2024

kulagaIA commented Feb 15, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Feb 15, 2024

kulagaIA commented Feb 15, 2024

davsclaus Feb 16, 2024

davsclaus commented Feb 17, 2024

CAMEL-20361: camel-jbang - Make jolokia pluggable for camel-platform-http-main #12985

CAMEL-20361: camel-jbang - Make jolokia pluggable for camel-platform-http-main #12985

Conversation

kulagaIA commented Feb 3, 2024 • edited Loading

Description

Tracking

github-actions bot commented Feb 3, 2024

kulagaIA commented Feb 3, 2024 • edited by github-actions bot Loading

kulagaIA commented Feb 3, 2024 • edited Loading

github-actions bot commented Feb 3, 2024

github-actions bot commented Feb 3, 2024

davsclaus Feb 3, 2024

Choose a reason for hiding this comment

kulagaIA commented Feb 3, 2024 • edited by github-actions bot Loading

github-actions bot commented Feb 3, 2024

davsclaus Feb 4, 2024

Choose a reason for hiding this comment

davsclaus Feb 4, 2024

Choose a reason for hiding this comment

davsclaus Feb 4, 2024

Choose a reason for hiding this comment

davsclaus commented Feb 4, 2024

davsclaus commented Feb 7, 2024

kulagaIA commented Feb 7, 2024 • edited Loading

davsclaus commented Feb 7, 2024

kulagaIA commented Feb 15, 2024 • edited by github-actions bot Loading

github-actions bot commented Feb 15, 2024

kulagaIA commented Feb 15, 2024 • edited by github-actions bot Loading

github-actions bot commented Feb 15, 2024

kulagaIA commented Feb 15, 2024

davsclaus Feb 16, 2024

Choose a reason for hiding this comment

davsclaus commented Feb 17, 2024

kulagaIA commented Feb 3, 2024 •

edited

Loading

kulagaIA commented Feb 3, 2024 •

edited by github-actions bot

Loading

kulagaIA commented Feb 3, 2024 •

edited

Loading

kulagaIA commented Feb 3, 2024 •

edited by github-actions bot

Loading

kulagaIA commented Feb 7, 2024 •

edited

Loading

kulagaIA commented Feb 15, 2024 •

edited by github-actions bot

Loading

kulagaIA commented Feb 15, 2024 •

edited by github-actions bot

Loading