Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of StringUtils.isMixedCase() #1096

Merged
merged 4 commits into from
Aug 16, 2023
Merged

Improve performance of StringUtils.isMixedCase() #1096

merged 4 commits into from
Aug 16, 2023

Commits on Aug 15, 2023

  1. improve performance of isMixedCase 

    The changes optimize the mixed-case detecting function in StringUtils.java by reducing redundant character property checks. The loop will now return early when both uppercase and lowercase are present, preventing further unnecessary operations. It also introduces a local variable to store the character being checked, reducing the number of method calls to get the character. The end return statement is also simplified to return false, as the true condition has already been covered inside the loop.
    @hduelme
    hduelme committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    4bfde0a View commit details
    Browse the repository at this point in the history

  2. add test to prove better performance

    @hduelme
    hduelme committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    7cd1faa View commit details
    Browse the repository at this point in the history

  3. Add Apache license header to StringUtilsIsMixedCaseTest.java file

    @hduelme
    hduelme committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    fcedff2 View commit details
    Browse the repository at this point in the history

  4. Fix Checkstyle issues

    @garydgregory
    garydgregory authored Aug 15, 2023
    Configuration menu
    Copy the full SHA
    0a31b33 View commit details
    Browse the repository at this point in the history