fix(android): prevent app crash caused by NPE on intent data or mediaFile #232
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
Motivation and Context
Prevent app crash after capture and show error if no content or no access to it
Description
Unify null checks for all three capture types, first on retrieved intent data uri (failing with
CAPTURE_NO_MEDIA_FILES
), and then on no mediaFile created (failing withCAPTURE_INTERNAL_ERR
)Testing
App crashing because of audio capture in some conditions (see #227 comment) now resolves with failure instead.
Not perfect, expecting #215 work on FileProvider to solve the problem but for now it is not an app crash anymore.
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)