Skip to content

Commit

Permalink
use .sk suffix on cross-lang filter binaries to avoid workflow changes
Browse files Browse the repository at this point in the history
  • Loading branch information
jmalkin committed Aug 14, 2024
1 parent 505a119 commit 533b6b9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion filters/test/bloom_filter_deserialize_from_java_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ TEST_CASE("bloom_filter", "[serde_compat]") {
for (const uint16_t num_hashes: h_arr) {
std::ifstream is;
is.exceptions(std::ios::failbit | std::ios::badbit);
is.open(testBinaryInputPath + "bf_n" + std::to_string(n) + "_h" + std::to_string(num_hashes) + "_cpp.filter", std::ios::binary);
is.open(testBinaryInputPath + "bf_n" + std::to_string(n) + "_h" + std::to_string(num_hashes) + "_cpp.sk", std::ios::binary);
auto bf = bloom_filter::deserialize(is);
REQUIRE(bf.is_empty() == (n == 0));
REQUIRE((bf.is_empty() || (bf.get_bits_used() > n / 10)));
Expand Down
2 changes: 1 addition & 1 deletion filters/test/bloom_filter_serialize_for_java.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ TEST_CASE("bloom filter generate", "[serialize_for_java]") {
if (n > 0) bf.update(std::nan("1")); // include a NaN if non-empty
REQUIRE(bf.is_empty() == (n == 0));
REQUIRE((bf.is_empty() || (bf.get_bits_used() > n / 10)));
std::ofstream os("bf_n" + std::to_string(n) + "_h" + std::to_string(num_hashes) + "_cpp.filter", std::ios::binary);
std::ofstream os("bf_n" + std::to_string(n) + "_h" + std::to_string(num_hashes) + "_cpp.sk", std::ios::binary);
bf.serialize(os);
}
}
Expand Down

0 comments on commit 533b6b9

Please sign in to comment.