Code

Bloom filter#438

Code

Merged

jmalkin merged 31 commits intoapache:masterapache/datasketches-cpp:masterfrom jmalkin:bloomjmalkin/datasketches-cpp:bloomCopy head branch name to clipboardAug 17, 2024

+2,995-8

Commits

Commits on Jul 14, 2024

• WIP: bloom filter. No serialization, incomplete testing

  jmalkin

  committed
  4f81030

Commits on Jul 16, 2024

• bug fixes, but still WIP

  jmalkin

  committed
  46e236c

• add missing header

  jmalkin

  committed
  2a103ce

• fix included header

  jmalkin

  committed
  30aa213

Commits on Jul 23, 2024

• Add builder methods, improve test coverage

  jmalkin

  committed
  e8c14d1

Commits on Aug 7, 2024

• Move to bit array as plain memory, move operations to static functions, to ultimately simplify memory handling with wrapped filters

  jmalkin

  committed
  a5686a6

• Add sstream header

  jmalkin

  committed
  9dbcde5

Commits on Aug 9, 2024

• move bit_array_ops functions to be inline, WIP: blooom serialization

  jmalkin

  committed
  8144869

• add missing bitset header

  jmalkin

  committed
  687611e

Commits on Aug 10, 2024

• WIP: start testing serialization. no wrapping yet

  jmalkin

  committed
  e8966ad

Commits on Aug 12, 2024

• fix types

  

  Jon

  committed
  4f7801c

• improve tests around counting false positive for consistency

  jmalkin

  committed
  df35436

Commits on Aug 13, 2024

• partial testing of initialize, no test of wrapping yet

  jmalkin

  committed
  3b1d10b

• test using raw memory from sketch vs serialization

  jmalkin

  committed
  1a44c44

• functionally complete, still need a bit more documentation

  jmalkin

  committed
  65bd15f

• finish documenting, add copy/move ctors and assignment operators

  jmalkin

  committed
  be58ab6

• fix allocator usage, add test_allocator test

  jmalkin

  committed
  2c70bbe

• actually add test_allocator test

  jmalkin

  committed
  66e64f2

• Add java serde compatibility tests

  jmalkin

  committed
  321f01d

• remove debug line that was no longer valid

  jmalkin

  committed
  6daa489

Commits on Aug 14, 2024

• Include NaN in language compatibility tests

  jmalkin

  committed
  505a119

• use .sk suffix on cross-lang filter binaries to avoid workflow changes

  jmalkin

  committed
  533b6b9

• Add class-level docs to bloom filter (and builder) and include the serialization format in the impl file

  jmalkin

  committed
  ecc856b

Commits on Aug 15, 2024

• Address most review feedback

  

  Jon

  committed
  5e62bc3

Commits on Aug 16, 2024

• remove const from copied primitives in method signatures

  jmalkin

  committed
  9d53c6c

• Merge branch 'bloom' of github.com:jmalkin/datasketches-cpp into bloom

  jmalkin

  committed
  0b575fe

• apparently i clobbered my own const removal edits..

  jmalkin

  committed
  1705e89

• managed to conflict with myself when jumping between boxes. resolved now.

  jmalkin

  committed
  1ac743f

• move builder class inside bloom_filter

  jmalkin

  committed
  fbc3119

Commits on Aug 17, 2024

• Remove unused and unnecessary forward declaration

  jmalkin

  committed
  822bd53

• no need for friend class with builder inside the filter

  jmalkin

  committed
  37f6531