Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cross-lang tests for Bloom filter #439

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Fix cross-lang tests for Bloom filter #439

merged 1 commit into from
Aug 20, 2024

Conversation

jmalkin
Copy link
Contributor

@jmalkin jmalkin commented Aug 19, 2024

  • fix type on num_hashes to uint16_t
  • change bloom_filter_filter to bloom_filter::builder

Added corresponding tests in java and verified locally in both directions.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10449096369

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.713%
Totals Coverage Status
Change from base Build 10429767489: 0.0%
Covered Lines: 16880
Relevant Lines: 17100
💛 - Coveralls

@jmalkin jmalkin merged commit bceeb2d into master Aug 20, 2024
8 checks passed
@jmalkin jmalkin deleted the bf_serde_compat_fix branch August 20, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSaydakov AlexanderSaydakov AlexanderSaydakov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmalkin @coveralls @AlexanderSaydakov