Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance dubbo-admin #1220

Closed
wants to merge 4 commits into from
Closed

enhance dubbo-admin #1220

wants to merge 4 commits into from

Conversation

sjmshsh
Copy link

@sjmshsh sjmshsh commented Aug 17, 2023

增加代码生成器简化后续开发流程。优化证书更新循环的停止逻辑。加上了一个模板Client作为参考。优化了日志。dds传输的资源中加入了key(cr资源的name/namespace组成)。

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2023

Codecov Report

Attention: Patch coverage is 56.11111% with 79 lines in your changes missing coverage. Please review.

Project coverage is 46.83%. Comparing base (8562ead) to head (a182780).

Current head a182780 differs from pull request most recent head 0823d8f

Please upload reports for the commit 0823d8f to get more accurate results.

Files Patch % Lines
pkg/core/cert/provider/client.go 0.00% 27 Missing ⚠️
pkg/core/cert/provider/storage.go 33.33% 21 Missing and 1 partial ⚠️
pkg/dds/kube/crdclient/handler.go 23.52% 9 Missing and 4 partials ⚠️
pkg/core/cert/provider/util.go 46.15% 7 Missing ⚠️
pkg/authority/server/authority.go 25.00% 6 Missing ⚠️
pkg/dds/kube/crdclient/client.go 70.00% 3 Missing ⚠️
pkg/dds/storage/storage.go 93.33% 1 Missing ⚠️
Additional details and impacted files
@@                             Coverage Diff                              @@
##           refactor-with-go-components-experimental    #1220      +/-   ##
============================================================================
+ Coverage                                     46.68%   46.83%   +0.14%     
============================================================================
  Files                                           113      113              
  Lines                                          6439     6472      +33     
  Branches                                         41       41              
============================================================================
+ Hits                                           3006     3031      +25     
- Misses                                         3142     3149       +7     
- Partials                                        291      292       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: wuyan-dushang <[email protected]>
Signed-off-by: wuyan-dushang <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Aug 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sjmshsh sjmshsh changed the title fix dubbo-admin enhance dubbo-admin Aug 18, 2023
@sjmshsh sjmshsh closed this by deleting the head repository Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants