add: Override registerServiceAppMapping #380
Conversation
| @Override | ||
| public boolean registerServiceAppMapping(String key, String group, String content, Object ticket) { | ||
| String appKey = toRootDir() + "mapping-data" + PATH_SEPARATOR + key + PATH_SEPARATOR + group; | ||
| if (!etcdClient.put(appKey, content)) { |
There was a problem hiding this comment.
1，The group is not at the end？
like this： toRootDir() + group + PATH_SEPARATOR + serviceKey,
2，etcd's put method does not support cas.
There was a problem hiding this comment.
1，The group is not at the end？ like this： toRootDir() + group + PATH_SEPARATOR + serviceKey, 2，etcd's put method does not support cas.
1、Can adjust
2、Does not support cas，etcd3 transaction?
| @@ -126,6 +126,16 @@ public String getServiceDefinition(MetadataIdentifier metadataIdentifier) { | |||
| return etcdClient.getKVValue(getNodeKey(metadataIdentifier)); | |||
| } | |||
|
|
|||
| @Override | |||
| public boolean registerServiceAppMapping(String key, String group, String content, Object ticket) { | |||
| String appKey = toRootDir() + "mapping-data" + PATH_SEPARATOR + key + PATH_SEPARATOR + group; | |||
There was a problem hiding this comment.
why use mapping-data ?
The "mapping-data" string is used as a part of the key for storing service application mappings in Etcd. In the context of this code, a service application mapping is a relationship between a service and an application, which is stored in Etcd for later retrieval.
There was a problem hiding this comment.
i found it has contanis mapping keywords
There was a problem hiding this comment.
That's okay, I just want metadata to look the same as mapping-data
What is the purpose of the change
fix issue: apache/dubbo#14164
Brief changelog
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily:
you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address
just this issue, without pulling in other changes - one PR resolves one issue.
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commitin the pull request should have a meaningful subject line and body.
exist. If the new feature or significant change is committed, please remember to add sample
in dubbo samples project.
mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sureunit-test and integration-test pass.
the Software Donation Guide.