Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-SPI-Extensions] Add Intergration Test #556

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

shaokeyibb
Copy link

@shaokeyibb shaokeyibb commented Nov 5, 2024

What is the purpose of the change

See: [General][Java SDK (Component)] Integrate spi-samples into github-action in the spi repository

Implemented an "intergration-test" github actions job.

cc: @heliang666s

Brief changelog

  • Modifed .github/workflows/build-and-test-pr.yml, add a new job named "intergration-test".

Verifying this change

Just see the "Intergration Test with JDK 8" checks below.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before
    you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address
    just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit
    in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency
    exist. If the new feature or significant change is committed, please remember to add sample
    in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure
    unit-test and integration-test pass.
  • If this contribution is large, please follow
    the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (9b48975) to head (c445157).
Report is 196 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##             master    #556      +/-   ##
===========================================
- Coverage      0.27%   0.00%   -0.28%     
===========================================
  Files           299     525     +226     
  Lines         13730   17566    +3836     
  Branches       1737    2040     +303     
===========================================
- Hits             38       0      -38     
- Misses        13689   17566    +3877     
+ Partials          3       0       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@wcy666103 wcy666103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change the flow for spi-Samples first.

with:
path: ${{ github.workspace }}/.tmp/rsa
key: secret-rsa-${{ runner.os }}-${{ github.run_id }}
- name: Calc Dubbo Version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach does not integrate the two test environments very well, you can check the log of the action, all tests are ignored.

Copy link
Author

@shaokeyibb shaokeyibb Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a known issue since most of spi-samples require their dubbo version to 3.2* which is configured in case-versions.conf instad of our 3.3.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a known issue since most of spi-samples require their dubbo version to 3.2* instad of our 3.3 which is configured in case-versions.conf.

So the logic of the spi-samples repository is broken, and I think it's enough to limit the spi-extensions version. The current configuration of the samples repository is just for use, not anything special.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants