-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dubbo-SPI-Extensions] Add Intergration Test #556
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #556 +/- ##
===========================================
- Coverage 0.27% 0.00% -0.28%
===========================================
Files 299 525 +226
Lines 13730 17566 +3836
Branches 1737 2040 +303
===========================================
- Hits 38 0 -38
- Misses 13689 17566 +3877
+ Partials 3 0 -3 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's change the flow for spi-Samples first.
with: | ||
path: ${{ github.workspace }}/.tmp/rsa | ||
key: secret-rsa-${{ runner.os }}-${{ github.run_id }} | ||
- name: Calc Dubbo Version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approach does not integrate the two test environments very well, you can check the log of the action, all tests are ignored.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a known issue since most of spi-samples require their dubbo version to 3.2*
which is configured in case-versions.conf
instad of our 3.3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a known issue since most of spi-samples require their dubbo version to
3.2*
instad of our 3.3 which is configured incase-versions.conf
.
So the logic of the spi-samples repository is broken, and I think it's enough to limit the spi-extensions version. The current configuration of the samples repository is just for use, not anything special.
What is the purpose of the change
See: [General][Java SDK (Component)] Integrate spi-samples into github-action in the spi repository
Implemented an "intergration-test" github actions job.
cc: @heliang666s
Brief changelog
.github/workflows/build-and-test-pr.yml
, add a new job named "intergration-test".Verifying this change
Just see the "Intergration Test with JDK 8" checks below.
Follow this checklist to help us incorporate your contribution quickly and easily:
you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address
just this issue, without pulling in other changes - one PR resolves one issue.
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commitin the pull request should have a meaningful subject line and body.
exist. If the new feature or significant change is committed, please remember to add sample
in dubbo samples project.
mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sureunit-test and integration-test pass.
the Software Donation Guide.