Skip to content

Commit

Permalink
[ISSUE #3009]change MetricsHandler#get to try-resources (#4800)
Browse files Browse the repository at this point in the history
  • Loading branch information
@TT432
TT432 authored Mar 21, 2024
1 parent 87172a9 commit 1640985
Showing 1 changed file with 62 additions and 67 deletions.
129 changes: 62 additions & 67 deletions ...mesh-runtime/src/main/java/org/apache/eventmesh/runtime/admin/handler/MetricsHandler.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -97,76 +97,71 @@ void preflight(HttpExchange httpExchange) throws IOException {
* @throws IOException if an I/O error occurs while handling the request
*/
void get(HttpExchange httpExchange) throws IOException {
OutputStream out = httpExchange.getResponseBody();
httpExchange.getResponseHeaders().add(EventMeshConstants.CONTENT_TYPE, EventMeshConstants.APPLICATION_JSON);
httpExchange.getResponseHeaders().add(EventMeshConstants.HANDLER_ORIGIN, "*");

try {
GetMetricsResponse getMetricsResponse = new GetMetricsResponse(
httpSummaryMetrics.maxHTTPTPS(),
httpSummaryMetrics.avgHTTPTPS(),
httpSummaryMetrics.maxHTTPCost(),
httpSummaryMetrics.avgHTTPCost(),
httpSummaryMetrics.avgHTTPBodyDecodeCost(),
httpSummaryMetrics.getHttpDiscard(),
httpSummaryMetrics.maxSendBatchMsgTPS(),
httpSummaryMetrics.avgSendBatchMsgTPS(),
httpSummaryMetrics.getSendBatchMsgNumSum(),
httpSummaryMetrics.getSendBatchMsgFailNumSum(),
httpSummaryMetrics.getSendBatchMsgFailRate(),
httpSummaryMetrics.getSendBatchMsgDiscardNumSum(),
httpSummaryMetrics.maxSendMsgTPS(),
httpSummaryMetrics.avgSendMsgTPS(),
httpSummaryMetrics.getSendMsgNumSum(),
httpSummaryMetrics.getSendMsgFailNumSum(),
httpSummaryMetrics.getSendMsgFailRate(),
httpSummaryMetrics.getReplyMsgNumSum(),
httpSummaryMetrics.getReplyMsgFailNumSum(),
httpSummaryMetrics.maxPushMsgTPS(),
httpSummaryMetrics.avgPushMsgTPS(),
httpSummaryMetrics.getHttpPushMsgNumSum(),
httpSummaryMetrics.getHttpPushFailNumSum(),
httpSummaryMetrics.getHttpPushMsgFailRate(),
httpSummaryMetrics.maxHTTPPushLatency(),
httpSummaryMetrics.avgHTTPPushLatency(),
httpSummaryMetrics.getBatchMsgQueueSize(),
httpSummaryMetrics.getSendMsgQueueSize(),
httpSummaryMetrics.getPushMsgQueueSize(),
httpSummaryMetrics.getHttpRetryQueueSize(),
httpSummaryMetrics.avgBatchSendMsgCost(),
httpSummaryMetrics.avgSendMsgCost(),
httpSummaryMetrics.avgReplyMsgCost(),

tcpSummaryMetrics.getRetrySize(),
tcpSummaryMetrics.getClient2eventMeshTPS(),
tcpSummaryMetrics.getEventMesh2mqTPS(),
tcpSummaryMetrics.getMq2eventMeshTPS(),
tcpSummaryMetrics.getEventMesh2clientTPS(),
tcpSummaryMetrics.getAllTPS(),
tcpSummaryMetrics.getAllConnections(),
tcpSummaryMetrics.getSubTopicNum());
String result = JsonUtils.toJSONString(getMetricsResponse);
byte[] bytes = Objects.requireNonNull(result).getBytes(Constants.DEFAULT_CHARSET);
httpExchange.sendResponseHeaders(200, bytes.length);
out.write(bytes);
} catch (Exception e) {
StringWriter writer = new StringWriter();
PrintWriter printWriter = new PrintWriter(writer);
e.printStackTrace(printWriter);
printWriter.flush();
String stackTrace = writer.toString();

Error error = new Error(e.toString(), stackTrace);
String result = JsonUtils.toJSONString(error);
byte[] bytes = Objects.requireNonNull(result).getBytes(Constants.DEFAULT_CHARSET);
httpExchange.sendResponseHeaders(500, bytes.length);
out.write(bytes);
} finally {
if (out != null) {
try {
out.close();
} catch (IOException e) {
log.warn("out close failed...", e);
try (OutputStream out = httpExchange.getResponseBody()) {
try {
GetMetricsResponse getMetricsResponse = new GetMetricsResponse(
httpSummaryMetrics.maxHTTPTPS(),
httpSummaryMetrics.avgHTTPTPS(),
httpSummaryMetrics.maxHTTPCost(),
httpSummaryMetrics.avgHTTPCost(),
httpSummaryMetrics.avgHTTPBodyDecodeCost(),
httpSummaryMetrics.getHttpDiscard(),
httpSummaryMetrics.maxSendBatchMsgTPS(),
httpSummaryMetrics.avgSendBatchMsgTPS(),
httpSummaryMetrics.getSendBatchMsgNumSum(),
httpSummaryMetrics.getSendBatchMsgFailNumSum(),
httpSummaryMetrics.getSendBatchMsgFailRate(),
httpSummaryMetrics.getSendBatchMsgDiscardNumSum(),
httpSummaryMetrics.maxSendMsgTPS(),
httpSummaryMetrics.avgSendMsgTPS(),
httpSummaryMetrics.getSendMsgNumSum(),
httpSummaryMetrics.getSendMsgFailNumSum(),
httpSummaryMetrics.getSendMsgFailRate(),
httpSummaryMetrics.getReplyMsgNumSum(),
httpSummaryMetrics.getReplyMsgFailNumSum(),
httpSummaryMetrics.maxPushMsgTPS(),
httpSummaryMetrics.avgPushMsgTPS(),
httpSummaryMetrics.getHttpPushMsgNumSum(),
httpSummaryMetrics.getHttpPushFailNumSum(),
httpSummaryMetrics.getHttpPushMsgFailRate(),
httpSummaryMetrics.maxHTTPPushLatency(),
httpSummaryMetrics.avgHTTPPushLatency(),
httpSummaryMetrics.getBatchMsgQueueSize(),
httpSummaryMetrics.getSendMsgQueueSize(),
httpSummaryMetrics.getPushMsgQueueSize(),
httpSummaryMetrics.getHttpRetryQueueSize(),
httpSummaryMetrics.avgBatchSendMsgCost(),
httpSummaryMetrics.avgSendMsgCost(),
httpSummaryMetrics.avgReplyMsgCost(),

tcpSummaryMetrics.getRetrySize(),
tcpSummaryMetrics.getClient2eventMeshTPS(),
tcpSummaryMetrics.getEventMesh2mqTPS(),
tcpSummaryMetrics.getMq2eventMeshTPS(),
tcpSummaryMetrics.getEventMesh2clientTPS(),
tcpSummaryMetrics.getAllTPS(),
tcpSummaryMetrics.getAllConnections(),
tcpSummaryMetrics.getSubTopicNum());
String result = JsonUtils.toJSONString(getMetricsResponse);
byte[] bytes = Objects.requireNonNull(result).getBytes(Constants.DEFAULT_CHARSET);
httpExchange.sendResponseHeaders(200, bytes.length);
out.write(bytes);
} catch (Exception e) {
try (StringWriter writer = new StringWriter()) {
try (PrintWriter printWriter = new PrintWriter(writer)) {
e.printStackTrace(printWriter);
}

String stackTrace = writer.toString();

Error error = new Error(e.toString(), stackTrace);
String result = JsonUtils.toJSONString(error);
byte[] bytes = Objects.requireNonNull(result).getBytes(Constants.DEFAULT_CHARSET);
httpExchange.sendResponseHeaders(500, bytes.length);
out.write(bytes);
}
}
}
Expand Down

0 comments on commit 1640985

Please sign in to comment.